Make transition-duration unsigned
authorMatthias Clasen <mclasen@redhat.com>
Mon, 22 Apr 2013 01:31:29 +0000 (21:31 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 22 Apr 2013 01:51:28 +0000 (21:51 -0400)
The code doesn't deal with negative durations, so better
don't allow them.

gtk/gtkstack.c
gtk/gtkstack.h

index c1d7f99dae0cdb13ae3dd9faa065994255b5fc25..5cd929a0dc64e04e5888f48625d0257d94debbd5 100644 (file)
@@ -103,7 +103,7 @@ struct _GtkStackPrivate {
   gboolean homogeneous;
 
   GtkStackTransitionType transition_type;
-  gint transition_duration;
+  guint transition_duration;
 
   GtkStackChildInfo *last_visible_child;
   cairo_surface_t *last_visible_surface;
@@ -216,7 +216,7 @@ gtk_stack_get_property (GObject   *object,
       g_value_set_string (value, gtk_stack_get_visible_child_name (stack));
       break;
     case PROP_TRANSITION_DURATION:
-      g_value_set_int (value, gtk_stack_get_transition_duration (stack));
+      g_value_set_uint (value, gtk_stack_get_transition_duration (stack));
       break;
     case PROP_TRANSITION_TYPE:
       g_value_set_enum (value, gtk_stack_get_transition_type (stack));
@@ -247,7 +247,7 @@ gtk_stack_set_property (GObject     *object,
       gtk_stack_set_visible_child_name (stack, g_value_get_string (value));
       break;
     case PROP_TRANSITION_DURATION:
-      gtk_stack_set_transition_duration (stack, g_value_get_int (value));
+      gtk_stack_set_transition_duration (stack, g_value_get_uint (value));
       break;
     case PROP_TRANSITION_TYPE:
       gtk_stack_set_transition_type (stack, g_value_get_enum (value));
@@ -1101,7 +1101,7 @@ gtk_stack_get_homogeneous (GtkStack *stack)
  *
  * Since: 3.10
  */
-gint
+guint
 gtk_stack_get_transition_duration (GtkStack *stack)
 {
   g_return_val_if_fail (GTK_IS_STACK (stack), 0);
@@ -1123,7 +1123,7 @@ gtk_stack_get_transition_duration (GtkStack *stack)
  */
 void
 gtk_stack_set_transition_duration (GtkStack *stack,
-                                   gint      transition_duration)
+                                   guint     transition_duration)
 {
   g_return_if_fail (GTK_IS_STACK (stack));
 
index a0136e7ace18eb16f5969fda8db3f15b15542505..46c73671c9c580f0dd5a0f751530844440796661 100644 (file)
@@ -79,8 +79,8 @@ void                   gtk_stack_set_homogeneous         (GtkStack
                                                           gboolean                homogeneous);
 gboolean               gtk_stack_get_homogeneous         (GtkStack               *stack);
 void                   gtk_stack_set_transition_duration (GtkStack               *stack,
-                                                          gint                    transition_duration);
-gint                   gtk_stack_get_transition_duration (GtkStack               *stack);
+                                                          guint                   transition_duration);
+guint                  gtk_stack_get_transition_duration (GtkStack               *stack);
 void                   gtk_stack_set_transition_type     (GtkStack               *stack,
                                                           GtkStackTransitionType  transition_type);
 GtkStackTransitionType gtk_stack_get_transition_type     (GtkStack               *stack);